• dingtianhong's avatar
    bonding: rebuild the lock use for bond_mii_monitor() · 4cb4f97b
    dingtianhong authored
    The bond_mii_monitor() still use bond lock to protect bond slave list,
    it is no effect, I have 2 way to fix the problem, move the RTNL to the
    top of the function, or add RCU to protect the bond slave list,
    according to the Jay Vosburgh's opinion, 10 times one second is a
    truely big performance loss if use RTNL to protect the whole monitor,
    so I would take the advice and use RCU to protect the bond slave list.
    
    The bond_has_slave() will not protect by anything, there will no things
    happen if the slave list is be changed, unless the bond was free, but
    it will not happened before the monitor, the bond will closed before
    be freed.
    
    The peers notify for the bond will calling curr_active_slave, so
    derefence the slave to make sure we will accessing the same slave
    if the curr_active_slave changed, as the rcu dereference need in
    read-side critical sector and bond_change_active_slave() will call
    it with no RCU hold,  so add peer notify in rcu_read_lock which
    will be nested in monitor.
    Suggested-by: default avatarJay Vosburgh <fubar@us.ibm.com>
    Suggested-by: default avatarVeaceslav Falico <vfalico@redhat.com>
    Signed-off-by: default avatarDing Tianhong <dingtianhong@huawei.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    4cb4f97b
bond_main.c 123 KB