• Eric Sandeen's avatar
    ext4: fix oops in trace_ext4_mb_release_group_pa · 4d547616
    Eric Sandeen authored
    Our QA reported an oops in the ext4_mb_release_group_pa tracing,
    and Josef Bacik pointed out that it was because we may have a
    non-null but uninitialized ac_inode in the allocation context.
    
    I can reproduce it when running xfstests with ext4 tracepoints on, 
    on a CONFIG_SLAB_DEBUG kernel.
    
    We call trace_ext4_mb_release_group_pa from 2 places, 
    ext4_mb_discard_group_preallocations and 
    ext4_mb_discard_lg_preallocations
    
    In both cases we allocate an ac as a container just for tracing (!)
    and never fill in the ac_inode.  There's no reason to be assigning,
    testing, or printing it as far as I can see, so just remove it from
    the tracepoint.
    Signed-off-by: default avatarEric Sandeen <sandeen@redhat.com>
    Reviewed-by: default avatarJosef Bacik <josef@redhat.com>
    Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
    4d547616
ext4.h 25.7 KB