• Zhihao Cheng's avatar
    ubi: ubi_wl_put_peb: Fix infinite loop when wear-leveling work failed · 4d57a733
    Zhihao Cheng authored
    Following process will trigger an infinite loop in ubi_wl_put_peb():
    
    	ubifs_bgt		ubi_bgt
    ubifs_leb_unmap
      ubi_leb_unmap
        ubi_eba_unmap_leb
          ubi_wl_put_peb	wear_leveling_worker
                              e1 = rb_entry(rb_first(&ubi->used)
    			  e2 = get_peb_for_wl(ubi)
    			  ubi_io_read_vid_hdr  // return err (flash fault)
    			  out_error:
    			    ubi->move_from = ubi->move_to = NULL
    			    wl_entry_destroy(ubi, e1)
    			      ubi->lookuptbl[e->pnum] = NULL
          retry:
            e = ubi->lookuptbl[pnum];	// return NULL
    	if (e == ubi->move_from) {	// NULL == NULL gets true
    	  goto retry;			// infinite loop !!!
    
    $ top
      PID USER      PR  NI    VIRT    RES    SHR S  %CPU %MEM     COMMAND
      7676 root     20   0       0      0      0 R 100.0  0.0  ubifs_bgt0_0
    
    Fix it by:
     1) Letting ubi_wl_put_peb() returns directly if wearl leveling entry has
        been removed from 'ubi->lookuptbl'.
     2) Using 'ubi->wl_lock' protecting wl entry deletion to preventing an
        use-after-free problem for wl entry in ubi_wl_put_peb().
    
    Fetch a reproducer in [Link].
    
    Fixes: 43f9b25a ("UBI: bugfix: protect from volume removal")
    Fixes: ee59ba8b ("UBI: Fix stale pointers in ubi->lookuptbl")
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=216111Signed-off-by: default avatarZhihao Cheng <chengzhihao1@huawei.com>
    Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
    4d57a733
wl.c 56.1 KB