• Peter Senna Tschudin's avatar
    drivers/net/ethernet/sun/sungem.c: fix error return code · 4df12834
    Peter Senna Tschudin authored
    The function gem_init_one() return 0 for success and negative value
    for most of its internal tests failures. There is one exception
    that is error case going to err_out_free_consistent:. For this error
    case, the function abort its success execution path, but returns non
    negative value, making it difficult for a caller function to notice
    the error.
    
    This patch fixes the error case that do not return negative value.
    
    This was found by Coccinelle, but the code change was made by hand.
    This patch is not robot generated.
    
    A simplified version of the semantic match that finds this problem is
    as follows: (http://coccinelle.lip6.fr/)
    
    // <smpl>
    (
    if@p1 (\(ret < 0\|ret != 0\))
     { ... return ret; }
    |
    ret@p1 = 0
    )
    ... when != ret = e1
        when != &ret
    *if(...)
    {
      ... when != ret = e2
          when forall
     return ret;
    }
    // </smpl>
    Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    4df12834
sungem.c 76.1 KB