• Hans Verkuil's avatar
    gpiolib: add flag to indicate if the irq is disabled · 4e9439dd
    Hans Verkuil authored
    GPIO drivers call gpiochip_(un)lock_as_irq whenever they want to use a gpio
    as an interrupt. This is done when the irq is requested and it marks the
    gpio as in use by an interrupt.
    
    This is problematic for cases where a gpio pin is used as an interrupt
    pin, then, after the irq is disabled, is used as a regular gpio pin.
    Currently it is not possible to do this other than by first freeing
    the interrupt so gpiochip_unlock_as_irq is called, since an attempt to
    switch the gpio direction for output will fail since gpiolib believes
    that the gpio is in use for an interrupt and it does not know that it
    the irq is actually disabled.
    
    There are currently two drivers that would like to be able to do this:
    the tda998x_drv.c driver where a regular gpio pin needs to be temporarily
    reconfigured as an interrupt pin during CEC calibration, and the cec-gpio
    driver where you want to configure the gpio pin as an interrupt while
    waiting for traffic over the CEC bus, or as a regular pin when receiving or
    transmitting a CEC message.
    
    The solution is to add a new flag that is set when the irq is enabled,
    and have gpiod_direction_output check for that flag.
    
    We also add functions that drivers that do not use GPIOLIB_IRQCHIP
    can call when they enable/disable the irq.
    Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    4e9439dd
gpiolib.c 118 KB