• Kees Cook's avatar
    media: mxl5005s: Bounds check size used for max array index · d5872e93
    Kees Cook authored
    The use of state->CH_Ctrl[i].size in a shift operation implies that its
    value can be as much as 32, but the state->CH_Ctrl[i].val array is only
    25 in size. Bounds check the size before shifting and looping. Fixes
    warnings seen with GCC 13:
    
    ../drivers/media/tuners/mxl5005s.c: In function 'MXL_ControlWrite_Group.isra':
    ../drivers/media/tuners/mxl5005s.c:3450:70: warning: array subscript 32 is above array bounds of 'u16[25]' {aka 'short unsigned int[25]'} [-Warray-bounds=]
     3450 | state->CH_Ctrl[i].val[j] = (u8)((value >> j) & 0x01);
          |  ~~~~~~~~~~~~~~~~~~~~~^~~
    ../drivers/media/tuners/mxl5005s.c:238:13: note: while referencing 'val'
      238 |         u16 val[25];    /* Binary representation of Value */
          |             ^~~
    
    Cc: Colin Ian King <colin.i.king@gmail.com>
    Signed-off-by: default avatarKees Cook <keescook@chromium.org>
    Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
    d5872e93
mxl5005s.c 126 KB