• Herbert Xu's avatar
    netpoll: Add drop checks to all entry points · 4ead4431
    Herbert Xu authored
    The netpoll entry checks are required to ensure that we don't
    receive normal packets when invoked via netpoll.  Unfortunately
    it only ever worked for the netif_receive_skb/netif_rx entry
    points.  The VLAN (and subsequently GRO) entry point didn't
    have the check and therefore can trigger all sorts of weird
    problems.
    
    This patch adds the netpoll check to all entry points.
    
    I'm still uneasy with receiving at all under netpoll (which
    apparently is only used by the out-of-tree kdump code).  The
    reason is it is perfectly legal to receive all data including
    headers into highmem if netpoll is off, but if you try to do
    that with netpoll on and someone gets a printk in an IRQ handler                                             
    you're going to get a nice BUG_ON.
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    4ead4431
vlan_core.c 3.18 KB