• Hou Tao's avatar
    bpf, perf: Use subprog name when reporting subprog ksymbol · 47df8a2f
    Hou Tao authored
    Since commit bfea9a85 ("bpf: Add name to struct bpf_ksym"), when
    reporting subprog ksymbol to perf, prog name instead of subprog name is
    used. The backtrace of bpf program with subprogs will be incorrect as
    shown below:
    
      ffffffffc02deace bpf_prog_e44a3057dcb151f8_overwrite+0x66
      ffffffffc02de9f7 bpf_prog_e44a3057dcb151f8_overwrite+0x9f
      ffffffffa71d8d4e trace_call_bpf+0xce
      ffffffffa71c2938 perf_call_bpf_enter.isra.0+0x48
    
    overwrite is the entry program and it invokes the overwrite_htab subprog
    through bpf_loop, but in above backtrace, overwrite program just jumps
    inside itself.
    
    Fixing it by using subprog name when reporting subprog ksymbol. After
    the fix, the output of perf script will be correct as shown below:
    
      ffffffffc031aad2 bpf_prog_37c0bec7d7c764a4_overwrite_htab+0x66
      ffffffffc031a9e7 bpf_prog_c7eb827ef4f23e71_overwrite+0x9f
      ffffffffa3dd8d4e trace_call_bpf+0xce
      ffffffffa3dc2938 perf_call_bpf_enter.isra.0+0x48
    
    Fixes: bfea9a85 ("bpf: Add name to struct bpf_ksym")
    Signed-off-by: default avatarHou Tao <houtao1@huawei.com>
    Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
    Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
    Link: https://lore.kernel.org/bpf/20221114095733.158588-1-houtao@huaweicloud.com
    47df8a2f
core.c 326 KB