• Arnd Bergmann's avatar
    spi/rockchip: avoid uninitialized-use warning · 97cf5669
    Arnd Bergmann authored
    We currently get a warning about potentially uninitialized variables
    in the rockchip spi driver, at least in certain toolchain versions:
    
    spi/spi-rockchip.c: In function 'rockchip_spi_prepare_dma':
    include/linux/dmaengine.h:796:2: warning: 'txdesc' may be used uninitialized in this function
    include/linux/dmaengine.h:796:2: warning: 'rxdesc' may be used uninitialized in this function
    
    The reason seems to be that gcc cannot know whether the value
    of the rs->rx and rs->tx variables change between the two points
    these are accessed.
    
    The code is actually correct, but to make this clearer to the
    compiler, this changes the conditionals to test for the local
    rxdesc/txdesc variables instead, which it knows won't change.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    97cf5669
spi-rockchip.c 20.1 KB