• Christian Brauner's avatar
    rtnetlink: require unique netns identifier · 4ff66cae
    Christian Brauner authored
    Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK
    it is possible for userspace to send us requests with three different
    properties to identify a target network namespace. This affects at least
    RTM_{NEW,SET}LINK. Each of them could potentially refer to a different
    network namespace which is confusing. For legacy reasons the kernel will
    pick the IFLA_NET_NS_PID property first and then look for the
    IFLA_NET_NS_FD property but there is no reason to extend this type of
    behavior to network namespace ids. The regression potential is quite
    minimal since the rtnetlink requests in question either won't allow
    IFLA_IF_NETNSID requests before 4.16 is out (RTM_{NEW,SET}LINK) or don't
    support IFLA_NET_NS_{PID,FD} (RTM_{DEL,GET}LINK) in the first place.
    Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
    Acked-by: default avatarJiri Benc <jbenc@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    4ff66cae
rtnetlink.c 113 KB