• Geert Uytterhoeven's avatar
    net: stmmac: sti: Fix uninitialized pointer dereference if !OF · 50262c85
    Geert Uytterhoeven authored
    If CONFIG_OF is not set:
    
    drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c: In function ‘sti_dwmac_parse_data’:
    drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c:318: warning: ‘rs’ is used uninitialized in this function
    
    of_property_read_string() will return -ENOSYS in this case, and rs will
    be an uninitialized pointer.
    
    While the fallback clock selection is already selected correctly in this
    case, the string comparisons should be skipped too, else the system will
    crash while dereferencing the uninitialized pointer.
    Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    50262c85
dwmac-sti.c 9.61 KB