• Mike Galbraith's avatar
    perf tools: Fix module symbol loading bug · 508c4d08
    Mike Galbraith authored
    Avi Kivity reported 'perf annotate' failures with modules, the
    requested function was not annotated.
    
    If there are no modules currently loaded, or the last module
    scanned is not loaded, dso__load_modules() steps on the value from
    dso__load_vmlinux(), so we happily load the kallsyms symbols on top
    of what we've already loaded.
    
    Fix that such that the total count of symbols loaded is returned.
    Should module symbol load fail after parsing of vmlinux, is's a
    hard failure, so do not silently fall-back to kallsyms.
    Reported-by: default avatarAvi Kivity <avi@redhat.com>
    Signed-off-by: default avatarMike Galbraith <efault@gmx.de>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: rostedt@goodmis.org
    Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Masami Hiramatsu <mhiramat@redhat.com>
    LKML-Reference: <1253697658.11461.36.camel@marge.simson.net>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    508c4d08
symbol.c 21.3 KB