• Geert Uytterhoeven's avatar
    [media] timberdale: VIDEO_TIMBERDALE should depend on HAS_DMA · 50d8e46f
    Geert Uytterhoeven authored
    If NO_DMA=y:
    
        warning: (VIDEO_OMAP2_VOUT && VIDEO_VIU && VIDEO_TIMBERDALE) selects VIDEOBUF_DMA_CONTIG which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA)
    
        drivers/built-in.o: In function `__videobuf_dc_free':
        videobuf-dma-contig.c:(.text+0x6f4d32): undefined reference to `dma_free_coherent'
        drivers/built-in.o: In function `__videobuf_dc_alloc':
        videobuf-dma-contig.c:(.text+0x6f4fe6): undefined reference to `dma_alloc_coherent'
        drivers/built-in.o: In function `__videobuf_mmap_mapper':
        videobuf-dma-contig.c:(.text+0x6f518e): undefined reference to `dma_free_coherent'
    
    Commit 24482922 ("[media] timberdale: do not select TIMB_DMA")
    dropped the dependency of VIDEO_TIMBERDALE on DMADEVICES, and thus the
    implicit dependency on HAS_DMA.  VIDEO_TIMBERDALE selects
    VIDEOBUF_DMA_CONTIG, which bypasses its dependency on HAS_DMA.  Make
    VIDEO_TIMBERDALE depend on HAS_DMA to fix this.
    Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
    50d8e46f
Kconfig 7.53 KB