• Kirill A. Shutemov's avatar
    efi/unaccepted: Fix soft lockups caused by parallel memory acceptance · 50e782a8
    Kirill A. Shutemov authored
    Michael reported soft lockups on a system that has unaccepted memory.
    This occurs when a user attempts to allocate and accept memory on
    multiple CPUs simultaneously.
    
    The root cause of the issue is that memory acceptance is serialized with
    a spinlock, allowing only one CPU to accept memory at a time. The other
    CPUs spin and wait for their turn, leading to starvation and soft lockup
    reports.
    
    To address this, the code has been modified to release the spinlock
    while accepting memory. This allows for parallel memory acceptance on
    multiple CPUs.
    
    A newly introduced "accepting_list" keeps track of which memory is
    currently being accepted. This is necessary to prevent parallel
    acceptance of the same memory block. If a collision occurs, the lock is
    released and the process is retried.
    
    Such collisions should rarely occur. The main path for memory acceptance
    is the page allocator, which accepts memory in MAX_ORDER chunks. As long
    as MAX_ORDER is equal to or larger than the unit_size, collisions will
    never occur because the caller fully owns the memory block being
    accepted.
    
    Aside from the page allocator, only memblock and deferered_free_range()
    accept memory, but this only happens during boot.
    
    The code has been tested with unit_size == 128MiB to trigger collisions
    and validate the retry codepath.
    
    Fixes: 2053bc57 ("efi: Add unaccepted memory support")
    Signed-off-by: default avatarKirill A. Shutemov <kirill.shutemov@linux.intel.com>
    Reported-by: Michael Roth <michael.roth@amd.com
    Reviewed-by: default avatarNikolay Borisov <nik.borisov@suse.com>
    Reviewed-by: default avatarVlastimil Babka <vbabka@suse.cz>
    Tested-by: default avatarMichael Roth <michael.roth@amd.com>
    [ardb: drop unnecessary cpu_relax() call]
    Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
    50e782a8
unaccepted_memory.c 5.84 KB