• Jakub Kicinski's avatar
    tls: splice_read: fix record type check · 520493f6
    Jakub Kicinski authored
    We don't support splicing control records. TLS 1.3 changes moved
    the record type check into the decrypt if(). The skb may already
    be decrypted and still be an alert.
    
    Note that decrypt_skb_update() is idempotent and updates ctx->decrypted
    so the if() is pointless.
    
    Reorder the check for decryption errors with the content type check
    while touching them. This part is not really a bug, because if
    decryption failed in TLS 1.3 content type will be DATA, and for
    TLS 1.2 it will be correct. Nevertheless its strange to touch output
    before checking if the function has failed.
    
    Fixes: fedf201e ("net: tls: Refactor control message handling on recv")
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    520493f6
tls_sw.c 64.8 KB