• Huang Ying's avatar
    crypto: gcm - fix another complete call in complete fuction · 62c5593a
    Huang Ying authored
    The flow of the complete function (xxx_done) in gcm.c is as follow:
    
    void complete(struct crypto_async_request *areq, int err)
    {
    	struct aead_request *req = areq->data;
    
    	if (!err) {
    		err = async_next_step();
    		if (err == -EINPROGRESS || err == -EBUSY)
    			return;
    	}
    
    	complete_for_next_step(areq, err);
    }
    
    But *areq may be destroyed in async_next_step(), this makes
    complete_for_next_step() can not work properly. To fix this, one of
    following methods is used for each complete function.
    
    - Add a __complete() for each complete(), which accept struct
      aead_request *req instead of areq, so avoid using areq after it is
      destroyed.
    
    - Expand complete_for_next_step().
    
    The fixing method is based on the idea of Herbert Xu.
    Signed-off-by: default avatarHuang Ying <ying.huang@intel.com>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    62c5593a
gcm.c 27.4 KB