• Wong Vee Khee's avatar
    net: stmmac: Fix potential integer overflow · 52e597d3
    Wong Vee Khee authored
    The commit d96febed ("net: stmmac: arrange Tx tail pointer update
    to stmmac_flush_tx_descriptors") introduced the following coverity
    warning:-
    
      1. Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)
         overflow_before_widen: Potentially overflowing expression
         'tx_q->cur_tx * desc_size' with type 'unsigned int' (32 bits,
         unsigned) is evaluated using 32-bit arithmetic, and then used in a
         context that expects an expression of type dma_addr_t (64 bits,
         unsigned).
    
    Fixed this by assigning tx_tail_addr to dma_addr_t type, as dma_addr_t
    datatype is decided by CONFIG_ARCH_DMA_ADDR_T_64_BIT.
    
    Fixes: d96febed ("net: stmmac: arrange Tx tail pointer update to stmmac_flush_tx_descriptors")
    Signed-off-by: default avatarWong Vee Khee <vee.khee.wong@linux.intel.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    52e597d3
stmmac.h 9 KB