• Gustavo A. R. Silva's avatar
    pinctrl: bcm2835: constify gpio_chip structure · 531bcf73
    Gustavo A. R. Silva authored
    This structure is only used to copy into other structure, so declare
    it as const.
    
    This issue was detected using Coccinelle and the following semantic patch:
    
    @r disable optional_qualifier@
    identifier i;
    position p;
    @@
    static struct gpio_chip i@p = { ... };
    
    @ok@
    identifier r.i;
    expression e;
    position p;
    @@
    e = i@p;
    
    @bad@
    position p != {r.p,ok.p};
    identifier r.i;
    struct gpio_chip e;
    @@
    e@i@p
    
    @depends on !bad disable optional_qualifier@
    identifier r.i;
    @@
    static
    +const
     struct gpio_chip i = { ... };
    
    In the following log you can see a significant difference in the code size
    and data segment, hence in the dec segment. This log is the output
    of the size command, before and after the code change:
    
    before:
       text    data     bss     dec     hex filename
      18958    9000     128   28086    6db6 drivers/pinctrl/bcm/pinctrl-bcm2835.o
    
    after:
       text    data     bss     dec     hex filename
      18764    8912     128   27804    6c9c drivers/pinctrl/bcm/pinctrl-bcm2835.o
    Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
    Acked-by: default avatarEric Anholt <eric@anholt.net>
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    531bcf73
pinctrl-bcm2835.c 28.4 KB