• Sagi Grimberg's avatar
    nvme: don't intialize hwmon for discovery controllers · 5ab25a32
    Sagi Grimberg authored
    Discovery controllers usually don't support smart log page command.
    So when we connect to the discovery controller we see this warning:
    nvme nvme0: Failed to read smart log (error 24577)
    nvme nvme0: new ctrl: NQN "nqn.2014-08.org.nvmexpress.discovery", addr 192.168.123.1:8009
    nvme nvme0: Removing ctrl: NQN "nqn.2014-08.org.nvmexpress.discovery"
    
    Introduce a new helper to understand if the controller is a discovery
    controller and use this helper to skip nvme_init_hwmon (also use it in
    other places that we check if the controller is a discovery controller).
    
    Fixes: 400b6a7b ("nvme: Add hardware monitoring support")
    Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
    Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
    5ab25a32
core.c 121 KB