• Arnd Bergmann's avatar
    rxrpc: fix uninitialized pointer dereference in debug code · 55cae7a4
    Arnd Bergmann authored
    A newly added bugfix caused an uninitialized variable to be
    used for printing debug output. This is harmless as long
    as the debug setting is disabled, but otherwise leads to an
    immediate crash.
    
    gcc warns about this when -Wmaybe-uninitialized is enabled:
    
    net/rxrpc/call_object.c: In function 'rxrpc_release_call':
    net/rxrpc/call_object.c:496:163: error: 'sp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    
    The initialization was removed but one of the users remains.
    This adds back the initialization.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Fixes: 372ee163 ("rxrpc: Fix races between skb free, ACK generation and replying")
    Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
    55cae7a4
call_object.c 20.5 KB