• Mikulas Patocka's avatar
    vt: fix cursor when clearing the screen · b2ecf006
    Mikulas Patocka authored
    The patch a6dbe442 ("vt: perform safe console erase in the right
    order") introduced a bug. The conditional do_update_region() was
    replaced by a call to update_region() that does contain the conditional
    already, but with unwanted extra side effects such as restoring the cursor
    drawing.
    
    In order to reproduce the bug:
    - use framebuffer console with the AMDGPU driver
    - type "links" to start the console www browser
    - press 'q' and space to exit links
    
    Now the cursor will be permanently visible in the center of the
    screen. It will stay there until something overwrites it.
    
    The bug goes away if we change update_region() back to the conditional
    do_update_region().
    
    [ nico: reworded changelog ]
    Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
    Reviewed-by: default avatarNicolas Pitre <nico@fluxnic.net>
    Cc: stable@vger.kernel.org
    Fixes: a6dbe442 ("vt: perform safe console erase in the right order")
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    b2ecf006
vt.c 112 KB