-
Guillaume Nault authored
Use the new dscp_t type to replace the tos field of struct fib4_rule, so that fib4-rules consistently ignore ECN bits. Before this patch, fib4-rules did accept rules with the high order ECN bit set (but not the low order one). Also, it relied on its callers masking the ECN bits of ->flowi4_tos to prevent those from influencing the result. This was brittle and a few call paths still do the lookup without masking the ECN bits first. After this patch fib4-rules only compare the DSCP bits. ECN can't influence the result anymore, even if the caller didn't mask these bits. Also, fib4-rules now must have both ECN bits cleared or they will be rejected. Signed-off-by:
Guillaume Nault <gnault@redhat.com> Acked-by:
David Ahern <dsahern@kernel.org> Reviewed-by:
Toke Høiland-Jørgensen <toke@redhat.com> Signed-off-by:
Jakub Kicinski <kuba@kernel.org>
563f8e97