• Jens Axboe's avatar
    io_uring/rw: disable IOCB_DIO_CALLER_COMP · 838b35bb
    Jens Axboe authored
    If an application does O_DIRECT writes with io_uring and the file system
    supports IOCB_DIO_CALLER_COMP, then completions of the dio write side is
    done from the task_work that will post the completion event for said
    write as well.
    
    Whenever a dio write is done against a file, the inode i_dio_count is
    elevated. This enables other callers to use inode_dio_wait() to wait for
    previous writes to complete. If we defer the full dio completion to
    task_work, we are dependent on that task_work being run before the
    inode i_dio_count can be decremented.
    
    If the same task that issues io_uring dio writes with
    IOCB_DIO_CALLER_COMP performs a synchronous system call that calls
    inode_dio_wait(), then we can deadlock as we're blocked sleeping on
    the event to become true, but not processing the completions that will
    result in the inode i_dio_count being decremented.
    
    Until we can guarantee that this is the case, then disable the deferred
    caller completions.
    
    Fixes: 099ada2c ("io_uring/rw: add write support for IOCB_DIO_CALLER_COMP")
    Reported-by: default avatarAndres Freund <andres@anarazel.de>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    838b35bb
rw.c 27.1 KB