• Daniel Vetter's avatar
    drm/rockchip: Drop explicit drm_mode_config_cleanup call · 56e35f85
    Daniel Vetter authored
    It's (almost, there's some iommu stuff without significance) right
    above the drm_dev_put().
    
    This is made possible by a preceeding patch which added a drmm_
    cleanup action to drm_mode_config_init(), hence all we need to do to
    ensure that drm_mode_config_cleanup() is run on final drm_device
    cleanup is check the new error code for _init().
    
    Aside: Another driver with a bit much devm_kzalloc, which should
    probably use drmm_kzalloc instead ...
    
    v2: Explain why this cleanup is possible (Laurent).
    
    v3: Jump out at the right label (Francesco)
    
    v4: Try again, kbuild caught that I didn't build test this properly
    ...
    
    v5: Use drmm_mode_config_init() for more clarity (Sam, Thomas)
    Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
    Cc: Sam Ravnborg <sam@ravnborg.org>
    Cc: Thomas Zimmermann <tzimmermann@suse.de>
    Cc: Francesco Lavra <francescolavra.fl@gmail.com>
    Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
    Cc: Sandy Huang <hjc@rock-chips.com>
    Cc: "Heiko Stübner" <heiko@sntech.de>
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: linux-rockchip@lists.infradead.org
    Link: https://patchwork.freedesktop.org/patch/msgid/20200323144950.3018436-38-daniel.vetter@ffwll.ch
    56e35f85
rockchip_drm_drv.c 12.1 KB