• Doug Anderson's avatar
    i2c: exynos5: Properly use the "noirq" variants of suspend/resume · 57186fe3
    Doug Anderson authored
    The original code for the exynos i2c controller registered for the
    "noirq" variants.  However during review feedback it was moved to
    SIMPLE_DEV_PM_OPS without anyone noticing that it meant we were no
    longer actually "noirq" (despite functions named
    exynos5_i2c_suspend_noirq and exynos5_i2c_resume_noirq).
    
    i2c controllers that might have wakeup sources on them seem to need to
    resume at noirq time so that the individual drivers can actually read
    the i2c bus to handle their wakeup.
    
    NOTE: I took the original review feedback from Wolfram and added
    poweroff, thaw, freeze, restore.
    
    This patch has only been compile-tested since I don't have all the
    patches needed to make my machine using this i2c driver actually
    suspend/resume.
    Signed-off-by: default avatarDoug Anderson <dianders@chromium.org>
    Acked-by: default avatarKukjin Kim <kgene.kim@samsung.com>
    Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
    57186fe3
i2c-exynos5.c 21.2 KB