• Geert Uytterhoeven's avatar
    serial_core: Fix pm imbalance on unbind · bf903c0c
    Geert Uytterhoeven authored
    When a serial port is closed, uart_close() takes care of shutting down the
    hardware, and powering it down.
    
    When a serial port is unbound while in use, uart_close() bypasses all of
    this, as this is supposed to be done through uart_hangup() (invoked via
    tty_vhangup() in uart_remove_one_port()).
    
    However, uart_hangup() does not set the hardware's power state, leaving it
    powered up.  This may also lead to unbounded nesting counts in clock and
    power management, depending on their internal implementation.
    
    Make sure to power down the port in uart_hangup(), except when the port is
    used as a serial console.
    
    For serial consoles, this operation must be postponed until after the port
    becomes completely unused. This case is not fixed yet, as it depends on a
    (future) fix for the tty->count vs. port->count imbalance on failed
    uart_open().
    
    After this, the module clock used by the sh-sci driver is disabled on
    unbind while the serial port is in use.
    Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    bf903c0c
serial_core.c 70.8 KB