• Andrew Morton's avatar
    revert "x86, serial: convert legacy COM ports to platform devices" · 57d4810e
    Andrew Morton authored
    Revert 7e92b4fc.  It broke Sébastien Dugué's
    machine and Jeff said (persuasively)
    
      This seems like it will break decades-long-working stuff, in favor of
      breaking new ground in our favorite area, "trusting the BIOS."
    
      It's just not worth it for serial ports, IMO.  Serial ports are something
      that just shouldn't break at this late stage in the game.  My new Intel
      platform boxes don't even have serial ports, so I question the value of
      messing with serial port probing even more...  because...  just wait a year,
      and your box won't have a serial port either!  :)
    
      I certainly don't object to the use of platform devices (or isa_driver),
      but the probe change seems questionable.  That's sorta analagous to
      rewriting the floppy driver probe routine.  Sure you could do it...  but why
      risk all that damage and go through debugging all over again?
    
      It seems clear from this report that we cannot, should not, trust BIOS for
      something (a) so simple and (b) that has been working for over a decade.
    
    Much discussion ensued and we've decided to have another go at all of this.
    
    Cc: Sébastien Dugué <sebastien.dugue@bull.net>
    Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
    Cc: Len Brown <lenb@kernel.org>
    Cc: Adam Belay <ambx1@neo.rr.com>
    Cc: Matthew Garrett <mjg59@srcf.ucam.org>
    Cc: Russell King <rmk@arm.linux.org.uk>
    Cc: Jeff Garzik <jeff@garzik.org>
    Acked-by: default avatarAlan Cox <alan@lxorguk.ukuu.org.uk>
    Cc: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
    Cc: Sascha Sommer <saschasommer@freenet.de>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    57d4810e
serial.h 1007 Bytes