• Ryusuke Konishi's avatar
    nilfs2: move page release outside of nilfs_delete_entry and nilfs_set_link · 584db20c
    Ryusuke Konishi authored
    Patch series "nilfs2: Folio conversions for directory paths".
    
    This series applies page->folio conversions to nilfs2 directory
    operations.  This reduces hidden compound_head() calls and also converts
    deprecated kmap calls to kmap_local in the directory code.
    
    Although nilfs2 does not yet support large folios, Matthew has done his
    best here to include support for large folios, which will be needed for
    devices with large block sizes.
    
    This series corresponds to the second half of the original post [1], but
    with two complementary patches inserted at the beginning and some
    adjustments, to prevent a kmap_local constraint violation found during
    testing with highmem mapping.
    
    [1] https://lkml.kernel.org/r/20231106173903.1734114-1-willy@infradead.org
    
    I have reviewed all changes and tested this for regular and small block
    sizes, both on machines with and without highmem mapping.  No issues
    found.
    
    
    This patch (of 17):
    
    In a few directory operations, the call to nilfs_put_page() for a page
    obtained using nilfs_find_entry() or nilfs_dotdot() is hidden in
    nilfs_set_link() and nilfs_delete_entry(), making it difficult to track
    page release and preventing change of its call position.
    
    By moving nilfs_put_page() out of these functions, this makes the page
    get/put correspondence clearer and makes it easier to swap
    nilfs_put_page() calls (and kunmap calls within them) when modifying
    multiple directory entries simultaneously in nilfs_rename().
    
    Also, update comments for nilfs_set_link() and nilfs_delete_entry() to
    reflect changes in their behavior.
    
    To make nilfs_put_page() visible from namei.c, this moves its definition
    to nilfs.h and replaces existing equivalents to use it, but the exposure
    of that definition is temporary and will be removed on a later kmap ->
    kmap_local conversion.
    
    Link: https://lkml.kernel.org/r/20231127143036.2425-1-konishi.ryusuke@gmail.com
    Link: https://lkml.kernel.org/r/20231127143036.2425-2-konishi.ryusuke@gmail.comSigned-off-by: default avatarRyusuke Konishi <konishi.ryusuke@gmail.com>
    Reviewed-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    584db20c
nilfs.h 12.7 KB