• Thomas Petazzoni's avatar
    char: misc: assign file->private_data in all cases · 585d98e0
    Thomas Petazzoni authored
    In fa1f68db ("drivers: misc: pass miscdevice pointer via file
    private data"), the misc driver infrastructure was changed to assigned
    file->private_data as a pointer to the 'struct miscdevice' that
    corresponds to the device being opened.
    
    However, this assignment was only done when the misc driver was
    declaring a driver-specific ->open() operation in its
    file_operations. This doesn't make sense, as the driver may not
    necessarily have a custom ->open() operation, and might still be
    interested in having file->private_data properly set for use in its
    ->read() and write() operations.
    
    Therefore, we move the assignment of file->private_data outside of the
    condition that tests whether a driver-specific ->open() operation was
    defined.
    Signed-off-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
    Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    585d98e0
misc.c 6.88 KB