• Bob Peterson's avatar
    GFS2: Reduce code redundancy writing log headers · 588bff95
    Bob Peterson authored
    Before this patch, there was a lot of code redundancy between functions
    log_write_header (which uses bio) and clean_journal (which uses
    buffer_head). This patch reduces the redundancy to simplify the code
    and make log header writing more consistent. We want more consistency
    and reduced redundancy because we plan to add a bunch of new fields
    to improve performance (by eliminating the local statfs and quota files)
    improve metadata integrity (by adding new crcs and such) and for better
    debugging (by adding new fields to track when and where metadata was
    pushed through the journals.) We don't want to duplicate setting these
    new fields, nor allow for human error in the process.
    
    This reduction in code redundancy is accomplished by introducing a new
    helper function, gfs2_write_log_header which uses bio rather than bh.
    That simplifies recovery function clean_journal() to use the new helper
    function and iomap rather than redundancy and block_map (and eventually
    we can maybe remove block_map). It also reduces our dependency on
    buffer_heads.
    Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
    588bff95
recovery.c 12.9 KB