• Ravi Bangoria's avatar
    perf trace: Fix call-graph output · 3a9e9a47
    Ravi Bangoria authored
    Recently, Arnaldo fixed global vs event specific --max-stack usage with
    commit bd3dda9a ("perf trace: Allow overriding global --max-stack
    per event"). This commit is having a regression when we don't use
    --max-stack at all with perf trace. Ex,
    
      $ ./perf trace record -g ls
      $ ./perf trace -i perf.data
         0.076 ( 0.002 ms): ls/9109 brk(
         0.196 ( 0.008 ms): ls/9109 access(filename: 0x9f998b70, mode: R
         0.209 ( 0.031 ms): ls/9109 open(filename: 0x9f998978, flags: CLOEXEC
    
    This is missing call-traces.
    After patch:
    
      $ ./perf trace -i perf.data
         0.076 ( 0.002 ms): ls/9109 brk(
                                    do_syscall_trace_leave ([kernel.kallsyms])
                                    [0] ([unknown])
                                    syscall_exit_work ([kernel.kallsyms])
                                    brk (/usr/lib64/ld-2.17.so)
                                    _dl_sysdep_start (/usr/lib64/ld-2.17.so)
                                    _dl_start_final (/usr/lib64/ld-2.17.so)
                                    _dl_start (/usr/lib64/ld-2.17.so)
                                    _start (/usr/lib64/ld-2.17.so)
         0.196 ( 0.008 ms): ls/9109 access(filename: 0x9f998b70, mode: R
                                    do_syscall_trace_leave ([kernel.kallsyms])
                                    [0] ([unknown])
    Signed-off-by: default avatarRavi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
    Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Fixes: bd3dda9a ("perf trace: Allow overriding global --max-stack per event")
    Link: http://lkml.kernel.org/r/20180130053053.13214-3-ravi.bangoria@linux.vnet.ibm.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    3a9e9a47
builtin-trace.c 87.9 KB