• Sameer Pujar's avatar
    ASoC: tegra: Fix clock DAI format on Tegra210 · 5983a8a4
    Sameer Pujar authored
    I2S reset failures are seen on Tegra210 and later platforms. This indicates
    absence of I2S bit clock, which is required to perform the reset operation.
    Following failures are seen with I2S based tests on Tegra210 and later:
    
      tegra210-i2s 2901100.i2s: timeout: failed to reset I2S for playback
      tegra210-i2s 2901100.i2s: ASoC: PRE_PMU: I2S2 RX event failed: -110
      tegra210-i2s 2901100.i2s: timeout: failed to reset I2S for capture
      tegra210-i2s 2901100.i2s: ASoC: PRE_PMU: I2S2 TX event failed: -110
    
    The commit d92ad663 ("ASoC: tegra: Update to use set_fmt_new callback")
    regressed I2S functionality on Tegra platforms. Basically it flipped clock
    provider and consumer DAI formats. This configures Tegra I2S in consumer
    mode by default now and there is none to provide bit clock during loopback
    tests. The external codec based tests also fail because both Tegra I2S and
    codec I2S get configured in consumer mode.
    
    ASoC core flips the DAI format before calling set_fmt() for CPU DAIs. This
    is negated in above commit. Fix this by swapping SND_SOC_DAIFMT_BC_FC and
    SND_SOC_DAIFMT_BP_FP switch cases.
    
    Fixes: d92ad663 ("ASoC: tegra: Update to use set_fmt_new callback")
    Signed-off-by: default avatarSameer Pujar <spujar@nvidia.com>
    Cc: Charles Keepax <ckeepax@opensource.cirrus.com>
    Link: https://lore.kernel.org/r/1655280277-4701-1-git-send-email-spujar@nvidia.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    5983a8a4
tegra210_i2s.c 26.7 KB