• Andi Kleen's avatar
    perf tools: Support weak groups in 'perf stat' · 5a5dfe4b
    Andi Kleen authored
    Setting up groups can be complicated due to the complicated scheduling
    restrictions of different PMUs.
    
    User tools usually don't understand all these restrictions.
    
    Still in many cases it is useful to set up groups and they work most of
    the time. However if the group is set up wrong some members will not
    report any value because they never get scheduled.
    
    Add a concept of a 'weak group': try to set up a group, but if it's not
    schedulable fallback to not using a group. That gives us the best of
    both worlds: groups if they work, but still a usable fallback if they
    don't.
    
    In theory it would be possible to have more complex fallback strategies
    (e.g. try to split the group in half), but the simple fallback of not
    using a group seems to work for now.
    
    So far the weak group is only implemented for perf stat, not for record.
    
    Here's an unschedulable group (on IvyBridge with SMT on)
    
      % perf stat -e '{branches,branch-misses,l1d.replacement,l2_lines_in.all,l2_rqsts.all_code_rd}' -a sleep 1
    
            73,806,067      branches
             4,848,144      branch-misses             #    6.57% of all branches
            14,754,458      l1d.replacement
            24,905,558      l2_lines_in.all
       <not supported>      l2_rqsts.all_code_rd         <------- will never report anything
    
    With the weak group:
    
      % perf stat -e '{branches,branch-misses,l1d.replacement,l2_lines_in.all,l2_rqsts.all_code_rd}:W' -a sleep 1
    
           125,366,055      branches                                                      (80.02%)
             9,208,402      branch-misses             #    7.35% of all branches          (80.01%)
            24,560,249      l1d.replacement                                               (80.00%)
            43,174,971      l2_lines_in.all                                               (80.05%)
            31,891,457      l2_rqsts.all_code_rd                                          (79.92%)
    
    The extra event scheduled with some extra multiplexing
    
    v2: Move fallback code to separate function.
    Add comment on for_each_group_member
    Adjust to new perf_evsel__close interface
    v3: Fix debug print out.
    
    Committer testing:
    
    Before:
    
      # perf stat -e '{branches,branch-misses,l1d.replacement,l2_lines_in.all,l2_rqsts.all_code_rd}' -a sleep 1
    
       Performance counter stats for 'system wide':
    
         <not counted>      branches
         <not counted>      branch-misses
         <not counted>      l1d.replacement
         <not counted>      l2_lines_in.all
       <not supported>      l2_rqsts.all_code_rd
    
           1.002147212 seconds time elapsed
    
      # perf stat -e '{branches,l1d.replacement,l2_lines_in.all,l2_rqsts.all_code_rd}' -a sleep 1
    
       Performance counter stats for 'system wide':
    
            83,207,892      branches
            11,065,444      l1d.replacement
            28,484,024      l2_lines_in.all
            12,186,179      l2_rqsts.all_code_rd
    
           1.001739493 seconds time elapsed
    
    After:
    
      # perf stat -e '{branches,branch-misses,l1d.replacement,l2_lines_in.all,l2_rqsts.all_code_rd}':W -a sleep 1
    
       Performance counter stats for 'system wide':
    
           543,323,909      branches                                                      (80.01%)
            27,100,512      branch-misses             #    4.99% of all branches          (80.02%)
            50,402,905      l1d.replacement                                               (80.03%)
            67,385,892      l2_lines_in.all                                               (80.01%)
            21,352,885      l2_rqsts.all_code_rd                                          (79.94%)
    
           1.001086658 seconds time elapsed
    
      #
    Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
    Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
    Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Link: http://lkml.kernel.org/r/20170831194036.30146-2-andi@firstfloor.org
    [ Add a "'perf stat' only, for now" comment in the man page, suggested by Jiri ]
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    5a5dfe4b
builtin-stat.c 69.5 KB