• Marc Zyngier's avatar
    ARM: KVM: switch to a dual-step HYP init code · 5a677ce0
    Marc Zyngier authored
    Our HYP init code suffers from two major design issues:
    - it cannot support CPU hotplug, as we tear down the idmap very early
    - it cannot perform a TLB invalidation when switching from init to
      runtime mappings, as pages are manipulated from PL1 exclusively
    
    The hotplug problem mandates that we keep two sets of page tables
    (boot and runtime). The TLB problem mandates that we're able to
    transition from one PGD to another while in HYP, invalidating the TLBs
    in the process.
    
    To be able to do this, we need to share a page between the two page
    tables. A page that will have the same VA in both configurations. All we
    need is a VA that has the following properties:
    - This VA can't be used to represent a kernel mapping.
    - This VA will not conflict with the physical address of the kernel text
    
    The vectors page seems to satisfy this requirement:
    - The kernel never maps anything else there
    - The kernel text being copied at the beginning of the physical memory,
      it is unlikely to use the last 64kB (I doubt we'll ever support KVM
      on a system with something like 4MB of RAM, but patches are very
      welcome).
    
    Let's call this VA the trampoline VA.
    
    Now, we map our init page at 3 locations:
    - idmap in the boot pgd
    - trampoline VA in the boot pgd
    - trampoline VA in the runtime pgd
    
    The init scenario is now the following:
    - We jump in HYP with four parameters: boot HYP pgd, runtime HYP pgd,
      runtime stack, runtime vectors
    - Enable the MMU with the boot pgd
    - Jump to a target into the trampoline page (remember, this is the same
      physical page!)
    - Now switch to the runtime pgd (same VA, and still the same physical
      page!)
    - Invalidate TLBs
    - Set stack and vectors
    - Profit! (or eret, if you only care about the code).
    
    Note that we keep the boot mapping permanently (it is not strictly an
    idmap anymore) to allow for CPU hotplug in later patches.
    Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
    Signed-off-by: default avatarChristoffer Dall <cdall@cs.columbia.edu>
    5a677ce0
init.S 4.29 KB