• Josef Bacik's avatar
    Btrfs: release metadata from global reserve if we have to fallback for unlink · 5a77d76c
    Josef Bacik authored
    I fixed a problem where we weren't reserving space for an orphan item when we
    had to fallback to using the global reserve for an unlink, but I introduced
    another problem.  I was migrating the bytes from the transaction reserve to the
    global reserve and then releasing from the global reserve in
    btrfs_end_transaction().  The problem with this is that a migrate will jack up
    the size for the destination, but leave the size alone for the source, with the
    idea that you can do a release normally on the source and it all washes out, and
    then you can do a release again on the destination and it works out right.  My
    way was skipping the release on the trans_block_rsv which still had the jacked
    up size from our original reservation.  So instead release manually from the
    global reserve if this transaction was using it, and then set the
    trans->block_rsv back to the trans_block_rsv so that btrfs_end_transaction
    cleans everything up properly.  With this patch xfstest 83 doesn't emit warnings
    about leaking space.  Thanks,
    Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
    Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
    5a77d76c
inode.c 198 KB