• Zeng Heng's avatar
    power: supply: fix residue sysfs file in error handle route of __power_supply_register() · 5b79480c
    Zeng Heng authored
    If device_add() succeeds, we should call device_del() when want to
    get rid of it, so move it into proper jump symbol.
    
    Otherwise, when __power_supply_register() returns fail and goto
    wakeup_init_failed to exit, there is still residue device file in sysfs.
    When attempt to probe device again, sysfs would complain as below:
    
    sysfs: cannot create duplicate filename '/devices/platform/i2c/i2c-0/0-001c/power_supply/adp5061'
    Call Trace:
     dump_stack_lvl+0x68/0x85
     sysfs_warn_dup.cold+0x1c/0x29
     sysfs_create_dir_ns+0x1b1/0x1d0
     kobject_add_internal+0x143/0x390
     kobject_add+0x108/0x170
    
    Fixes: 80c6463e ("power_supply: Fix Oops from NULL pointer dereference from wakeup_source_activate")
    Signed-off-by: default avatarZeng Heng <zengheng4@huawei.com>
    Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
    5b79480c
power_supply_core.c 42.5 KB