• Fabio M. De Francesco's avatar
    fs/isofs: replace kmap() with kmap_local_page() · 5bb6ce3a
    Fabio M. De Francesco authored
    The use of kmap() is being deprecated in favor of kmap_local_page().
    
    There are two main problems with kmap(): (1) It comes with an overhead as
    mapping space is restricted and protected by a global lock for
    synchronization and (2) it also requires global TLB invalidation when the
    kmap's pool wraps and it might block when the mapping space is fully
    utilized until a slot becomes available.
    
    With kmap_local_page() the mappings are per thread, CPU local, can take
    page faults, and can be called from any context (including interrupts). 
    Tasks can be preempted and, when scheduled to run again, the kernel
    virtual addresses are restored and still valid.  It is faster than kmap()
    in kernels with HIGHMEM enabled.
    
    Since kmap_local_page() can be safely used in compress.c, it should be
    called everywhere instead of kmap().
    
    Therefore, replace kmap() with kmap_local_page() in compress.c.  Where it
    is needed, use memzero_page() instead of open coding kmap_local_page()
    plus memset() to fill the pages with zeros.  Delete the redundant
    flush_dcache_page() in the two call sites of memzero_page().
    
    Tested with mkisofs on a QEMU/KVM x86_32 VM, 6GB RAM, booting a kernel
    with HIGHMEM64GB enabled.
    
    Link: https://lkml.kernel.org/r/20220801122709.8164-1-fmdefrancesco@gmail.comSigned-off-by: default avatarFabio M. De Francesco <fmdefrancesco@gmail.com>
    Suggested-by: default avatarIra Weiny <ira.weiny@intel.com>
    Reviewed-by: default avatarJan Kara <jack@suse.cz>
    Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
    Cc: Roman Gushchin <roman.gushchin@linux.dev>
    Cc: Pali Rohár <pali@kernel.org>
    Cc: Muchun Song <songmuchun@bytedance.com>
    Cc: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    5bb6ce3a
compress.c 10.1 KB