• Jon Paul Maloy's avatar
    tipc: small cleanup of function tipc_node_check_state() · 5c10e979
    Jon Paul Maloy authored
    The function tipc_node_check_state() contains the core logics
    for handling link synchronization and failover. For this reason,
    it is important to keep it as comprehensible as possible.
    
    In this commit, we make three small cleanups.
    
    1) If the node is in state SELF_DOWN_PEER_LEAVING and the received
       packet confirms that the peer has lost contact, there will be no
       further action in this function. To make this clearer, we return
       from the function directly after the state change.
    
    2) Since commit 0f8b8e28 ("tipc: eliminate risk of stalled
       link synchronization") only the logically first TUNNEL_PROTO/SYNCH
       packet can alter the link state and set the synch point,
       independently of arrival order. Hence, there is not any longer any
       need to adjust the synch value in case such packets arrive in
       disorder. We remove this adjustment.
    
    3) It is the intention that any message arriving on any of the links
       may trig a check for and possible termination of a node SYNCH state.
       A redundant and unnoticed check for tipc_link_is_synching() obviously
       beats this purpose, with the effect that only packets arriving on the
       synching link may currently end the synch state. We remove this check.
       This change will further shorten the synchronization period between
       parallel links.
    Reviewed-by: default avatarYing Xue <ying.xue@windriver.com>
    Signed-off-by: default avatarJon Maloy <jon.maloy@ericsson.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    5c10e979
node.c 36.4 KB