• Leonid Ravich's avatar
    IB/mad: Don't call to function that might sleep while in atomic context · 5c20311d
    Leonid Ravich authored
    Tracepoints are not allowed to sleep, as such the following splat is
    generated due to call to ib_query_pkey() in atomic context.
    
    WARNING: CPU: 0 PID: 1888000 at kernel/trace/ring_buffer.c:2492 rb_commit+0xc1/0x220
    CPU: 0 PID: 1888000 Comm: kworker/u9:0 Kdump: loaded Tainted: G           OE    --------- -  - 4.18.0-305.3.1.el8.x86_64 #1
     Hardware name: Red Hat KVM, BIOS 1.13.0-2.module_el8.3.0+555+a55c8938 04/01/2014
     Workqueue: ib-comp-unb-wq ib_cq_poll_work [ib_core]
     RIP: 0010:rb_commit+0xc1/0x220
     RSP: 0000:ffffa8ac80f9bca0 EFLAGS: 00010202
     RAX: ffff8951c7c01300 RBX: ffff8951c7c14a00 RCX: 0000000000000246
     RDX: ffff8951c707c000 RSI: ffff8951c707c57c RDI: ffff8951c7c14a00
     RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
     R10: ffff8951c7c01300 R11: 0000000000000001 R12: 0000000000000246
     R13: 0000000000000000 R14: ffffffff964c70c0 R15: 0000000000000000
     FS:  0000000000000000(0000) GS:ffff8951fbc00000(0000) knlGS:0000000000000000
     CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
     CR2: 00007f20e8f39010 CR3: 000000002ca10005 CR4: 0000000000170ef0
     Call Trace:
      ring_buffer_unlock_commit+0x1d/0xa0
      trace_buffer_unlock_commit_regs+0x3b/0x1b0
      trace_event_buffer_commit+0x67/0x1d0
      trace_event_raw_event_ib_mad_recv_done_handler+0x11c/0x160 [ib_core]
      ib_mad_recv_done+0x48b/0xc10 [ib_core]
      ? trace_event_raw_event_cq_poll+0x6f/0xb0 [ib_core]
      __ib_process_cq+0x91/0x1c0 [ib_core]
      ib_cq_poll_work+0x26/0x80 [ib_core]
      process_one_work+0x1a7/0x360
      ? create_worker+0x1a0/0x1a0
      worker_thread+0x30/0x390
      ? create_worker+0x1a0/0x1a0
      kthread+0x116/0x130
      ? kthread_flush_work_fn+0x10/0x10
      ret_from_fork+0x35/0x40
     ---[ end trace 78ba8509d3830a16 ]---
    
    Fixes: 821bf1de ("IB/MAD: Add recv path trace point")
    Signed-off-by: default avatarLeonid Ravich <lravich@gmail.com>
    Link: https://lore.kernel.org/r/Y2t5feomyznrVj7V@leonid-Inspiron-3421Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
    5c20311d
mad.c 88 KB