• Rene Herman's avatar
    PNP: do not test PNP_DRIVER_RES_DO_NOT_CHANGE on suspend/resume · 5d38998e
    Rene Herman authored
    The PNP_DRIVER_RES_DO_NOT_CHANGE flag is meant to signify that the PNP core
    should not change resources for the device -- not that it shouldn't
    disable/enable the device on suspend/resume.
    
    ALSA ISAPnP drivers set PNP_DRIVER_RES_DO_NOT_CHANAGE (0x0001) through
    setting PNP_DRIVER_RES_DISABLE (0x0003).  The latter including the former
    may in itself be considered rather unexpected but doesn't change that
    suspend/resume wouldn't seem to have any business testing the flag.
    
    As reported by Ondrej Zary for snd-cs4236, ALSA driven ISAPnP cards don't
    survive swsusp hibernation with the resume skipping setting the resources
    due to testing the flag -- the same test in the suspend path isn't enough
    to keep hibernation from disabling the card it seems.
    
    These tests were added (in 2005) by Piere Ossman in commit
    68094e32, "alsa: Improved PnP suspend
    support" who doesn't remember why.  This deletes them.
    Signed-off-by: default avatarRene Herman <rene.herman@gmail.com>
    Tested-by: default avatarOndrej Zary <linux@rainbow-software.org>
    Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
    Cc: Pierre Ossman <drzeus@drzeus.cx>
    Cc: Adam Belay <ambx1@neo.rr.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    5d38998e
driver.c 4.98 KB