• Roel Kluin's avatar
    EtherExpress16: fix printing timed out status · 684f4a4c
    Roel Kluin authored
    in drivers/net/eexpress.c:558, function unstick_cu()
    
    while (!SCB_complete(rsst=scb_status(dev))) {
    	...
    	if (...)
    		printk(KERN_WARNING "%s: Reset timed out status %04x, retrying...\n",
                                                           dev->name,rsst);
    }
    
    but this will become 
    
    while (!((rsst = scb_status(dev) & 0x8000) != 0) ...
    
    because of the macro:
    
    #define SCB_complete(s) ((s&0x8000)!=0)
    
    so rsst can only become either 0x8000 or 0, but in the latter case the
    loop ends, I think the wrong timed out status is printed. This also
    cleans up similar macros.
    Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    684f4a4c
eexpress.h 4.85 KB