• Krzysztof Kozlowski's avatar
    arm64: dts: imx8mm: correct interrupt flags · 5f67317b
    Krzysztof Kozlowski authored
    GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
    These are simple defines so they could be used in DTS but they will not
    have the same meaning:
    1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
    2. GPIO_ACTIVE_LOW  = 1 = IRQ_TYPE_EDGE_RISING
    
    Correct the interrupt flags, assuming the author of the code wanted same
    logical behavior behind the name "ACTIVE_xxx", this is:
      ACTIVE_LOW  => IRQ_TYPE_LEVEL_LOW
      ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH
    
    In case of level low interrupts, enable also internal pull up.  It is
    required at least on imx8mm-evk, according to schematics.
    
    The schematics for Variscite imx8mm-var-som are not available and
    I was unable to get proper configuration from Variscite.
    Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
    Acked-By: default avatarTim Harvey <tharvey@gateworks.com>
    Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
    5f67317b
imx8mm-evk.dtsi 10.3 KB