• Max Kellermann's avatar
    parisc/kprobes: always include asm-generic/kprobes.h · f945a404
    Max Kellermann authored
    The NOKPROBE_SYMBOL macro (and others) were moved to
    asm-generic/kprobes.h in 2017 by commit 7d134b2c ("kprobes: move
    kprobe declarations to asm-generic/kprobes.h"), and this new header
    was included by asm/kprobes.h unconditionally on all architectures.
    
    When kprobe support was added to parisc in 2017 by commit
    8858ac8e ("parisc: Implement kprobes"), that header was only
    included when CONFIG_KPROBES was enabled.
    
    This can lead to build failures when NOKPROBE_SYMBOL is used, but
    CONFIG_KPROBES is disabled.  This mistake however was never actually
    noticed because linux/kprobes.h also includes asm-generic/kprobes.h
    (though I do not understand why that is, because it also includes
    asm/kprobes.h).
    
    To prevent eventual build failures, I suggest to always include
    asm-generic/kprobes.h on parisc, just like all the other architectures
    do.  This way, including asm/kprobes.h suffices, and nobody (outside
    of arch/) ever needs to explicitly include asm-generic/kprobes.h.
    Signed-off-by: default avatarMax Kellermann <max.kellermann@ionos.com>
    Signed-off-by: default avatarHelge Deller <deller@gmx.de>
    f945a404
kprobes.h 1.31 KB