• Mika Westerberg's avatar
    gpio / ACPI: Rework ACPI GPIO event handling · 6072b9dc
    Mika Westerberg authored
    The current ACPI GPIO event handling code was never tested against real
    hardware with functioning GPIO triggered events (at the time such hardware
    wasn't available). Thus it misses certain things like requesting the GPIOs
    properly, passing correct flags to the interrupt handler and so on.
    
    This patch reworks ACPI GPIO event handling so that we:
    
     1) Use struct acpi_gpio_event for all GPIO signaled events.
     2) Switch to use GPIO descriptor API and request GPIOs by calling
        gpiochip_request_own_desc() that we added in a previous patch.
     3) Pass proper flags from ACPI GPIO resource to request_threaded_irq().
    
    Also instead of open-coding the _AEI iteration loop we can use
    acpi_walk_resources(). This simplifies the code a bit and fixes memory leak
    that was caused by missing kfree() for buffer returned by
    acpi_get_event_resources().
    
    Since the remove path now calls gpiochip_free_own_desc() which takes GPIO
    spinlock we need to call acpi_gpiochip_remove() outside of that lock
    (analogous to acpi_gpiochip_add() path where the lock is released before
    those funtions are called).
    Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
    Reviewed-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    6072b9dc
gpiolib-acpi.c 9.34 KB