• Jarek Poplawski's avatar
    pkt_sched: Fix lockdep warning on est_tree_lock in gen_estimator · 0b5d404e
    Jarek Poplawski authored
    This patch fixes a lockdep warning:
    
    [  516.287584] =========================================================
    [  516.288386] [ INFO: possible irq lock inversion dependency detected ]
    [  516.288386] 2.6.35b #7
    [  516.288386] ---------------------------------------------------------
    [  516.288386] swapper/0 just changed the state of lock:
    [  516.288386]  (&qdisc_tx_lock){+.-...}, at: [<c12eacda>] est_timer+0x62/0x1b4
    [  516.288386] but this lock took another, SOFTIRQ-unsafe lock in the past:
    [  516.288386]  (est_tree_lock){+.+...}
    [  516.288386] 
    [  516.288386] and interrupts could create inverse lock ordering between them.
    ...
    
    So, est_tree_lock needs BH protection because it's taken by
    qdisc_tx_lock, which is used both in BH and process contexts.
    (Full warning with this patch at netdev, 02 Sep 2010.)
    
    Fixes commit: ae638c47
    ("pkt_sched: gen_estimator: add a new lock")
    Signed-off-by: default avatarJarek Poplawski <jarkao2@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    0b5d404e
gen_estimator.c 8.63 KB