• Linus Torvalds's avatar
    Revert "ext4: don't release page refs in ext4_end_bio()" · 6268b325
    Linus Torvalds authored
    This reverts commit b43d17f3.
    
    Dave Jones reports that it causes lockups on his laptop, and his debug
    output showed a lot of processes hung waiting for page_writeback (or
    more commonly - processes hung waiting for a lock that was held during
    that writeback wait).
    
    The page_writeback hint made Ted suggest that Dave look at this commit,
    and Dave verified that reverting it makes his problems go away.
    
    Ted says:
     "That commit fixes a race which is seen when you write into fallocated
      (and hence uninitialized) disk blocks under *very* heavy memory
      pressure.  Furthermore, although theoretically it could trigger under
      normal direct I/O writes, it only seems to trigger if you are issuing
      a huge number of AIO writes, such that a just-written page can get
      evicted from memory, and then read back into memory, before the
      workqueue has a chance to update the extent tree.
    
      This race has been around for a little over a year, and no one noticed
      until two months ago; it only happens under fairly exotic conditions,
      and in fact even after trying very hard to create a simple repro under
      lab conditions, we could only reproduce the problem and confirm the
      fix on production servers running MySQL on very fast PCIe-attached
      flash devices.
    
      Given that Dave was able to hit this problem pretty quickly, if we
      confirm that this commit is at fault, the only reasonable thing to do
      is to revert it IMO."
    Reported-and-tested-by: default avatarDave Jones <davej@redhat.com>
    Acked-by: default avatarTheodore Ts'o <tytso@mit.edu>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    6268b325
page-io.c 11.3 KB