• Filipe Manana's avatar
    btrfs: adapt lru cache to allow for 64 bits keys on 32 bits systems · 6273ee62
    Filipe Manana authored
    The lru cache is backed by a maple tree, which uses the unsigned long
    type for keys, and that type has a width of 32 bits on 32 bits systems
    and a width of 64 bits on 64 bits systems.
    
    Currently there is only one user of the lru cache, the send backref cache,
    which uses a sector number as a key, a logical address right shifted by
    fs_info->sectorsize_bits, so a 32 bits width is not yet a problem (the
    same happens with the radix tree we use to track extent buffers,
    fs_info->buffer_radix).
    
    However the next patches in the series will start using the lru cache for
    cases where inode numbers are the keys, and the inode numbers are always
    64 bits, even if we are running on a 32 bits system.
    
    So adapt the lru cache to allow multiple values under the same key, by
    having the maple tree store a head entry that points to a list of entries
    instead of pointing to a single entry. This is a similar approach to what
    we currently do for the name cache in send (which uses a radix tree that
    has indexes with an unsigned long type as well), and will allow later to
    use the lru cache for the send name cache as well.
    
    This patch is part of a larger patchset and the changelog of the last
    patch in the series contains a sample performance test and results.
    The patches that comprise the patchset are the following:
    
      btrfs: send: directly return from did_overwrite_ref() and simplify it
      btrfs: send: avoid unnecessary generation search at did_overwrite_ref()
      btrfs: send: directly return from will_overwrite_ref() and simplify it
      btrfs: send: avoid extra b+tree searches when checking reference overrides
      btrfs: send: remove send_progress argument from can_rmdir()
      btrfs: send: avoid duplicated orphan dir allocation and initialization
      btrfs: send: avoid unnecessary orphan dir rbtree search at can_rmdir()
      btrfs: send: reduce searches on parent root when checking if dir can be removed
      btrfs: send: iterate waiting dir move rbtree only once when processing refs
      btrfs: send: initialize all the red black trees earlier
      btrfs: send: genericize the backref cache to allow it to be reused
      btrfs: adapt lru cache to allow for 64 bits keys on 32 bits systems
      btrfs: send: cache information about created directories
      btrfs: allow a generation number to be associated with lru cache entries
      btrfs: add an api to delete a specific entry from the lru cache
      btrfs: send: use the lru cache to implement the name cache
      btrfs: send: update size of roots array for backref cache entries
      btrfs: send: cache utimes operations for directories if possible
    Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
    Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    6273ee62
lru_cache.c 3.31 KB