• Fugang Duan's avatar
    net: fec: Don't clear IPV6 header checksum field when IP accelerator enable · 62a02c98
    Fugang Duan authored
    The commit 96c50caa (net: fec: Enable IP header hardware checksum)
    enable HW IP header checksum for IPV4 and IPV6, which causes IPV6 TCP/UDP
    cannot work. (The issue is reported by Russell King)
    
    For FEC IP header checksum function: Insert IP header checksum. This "IINS"
    bit is written by the user. If set, IP accelerator calculates the IP header
    checksum and overwrites the IINS corresponding header field with the calculated
    value. The checksum field must be cleared by user, otherwise the checksum
    always is 0xFFFF.
    
    So the previous patch clear IP header checksum field regardless of IP frame
    type.
    
    In fact, IP HW detect the packet as IPV6 type, even if the "IINS" bit is set,
    the IP accelerator is not triggered to calculates IPV6 header checksum because
    IPV6 frame format don't have checksum.
    
    So this results in the IPV6 frame being corrupted.
    
    The patch just add software detect the current packet type, if it is IPV6
    frame, it don't clear IP header checksum field.
    
    Cc: Russell King <linux@arm.linux.org.uk>
    Reported-and-tested-by: default avatarRussell King <linux@arm.linux.org.uk>
    Signed-off-by: default avatarFugang Duan <B38611@freescale.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    62a02c98
fec_main.c 69.6 KB