• Daniel Vetter's avatar
    PCI: Revoke mappings like devmem · 636b21b5
    Daniel Vetter authored
    Since 3234ac66 ("/dev/mem: Revoke mappings when a driver claims
    the region") /dev/kmem zaps PTEs when the kernel requests exclusive
    acccess to an iomem region. And with CONFIG_IO_STRICT_DEVMEM, this is
    the default for all driver uses.
    
    Except there are two more ways to access PCI BARs: sysfs and proc mmap
    support. Let's plug that hole.
    
    For revoke_devmem() to work we need to link our vma into the same
    address_space, with consistent vma->vm_pgoff. ->pgoff is already
    adjusted, because that's how (io_)remap_pfn_range works, but for the
    mapping we need to adjust vma->vm_file->f_mapping. The cleanest way is
    to adjust this at at ->open time:
    
    - for sysfs this is easy, now that binary attributes support this. We
      just set bin_attr->mapping when mmap is supported
    - for procfs it's a bit more tricky, since procfs PCI access has only
      one file per device, and access to a specific resource first needs
      to be set up with some ioctl calls. But mmap is only supported for
      the same resources as sysfs exposes with mmap support, and otherwise
      rejected, so we can set the mapping unconditionally at open time
      without harm.
    
    A special consideration is for arch_can_pci_mmap_io() - we need to
    make sure that the ->f_mapping doesn't alias between ioport and iomem
    space. There are only 2 ways in-tree to support mmap of ioports: generic
    PCI mmap (ARCH_GENERIC_PCI_MMAP_RESOURCE), and sparc as the single
    architecture hand-rolling. Both approaches support ioport mmap through a
    special PFN range and not through magic PTE attributes. Aliasing is
    therefore not a problem.
    
    The only difference in access checks left is that sysfs PCI mmap does
    not check for CAP_RAWIO. I'm not really sure whether that should be
    added or not.
    Acked-by: default avatarBjorn Helgaas <bhelgaas@google.com>
    Reviewed-by: default avatarDan Williams <dan.j.williams@intel.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
    Cc: Stephen Rothwell <sfr@canb.auug.org.au>
    Cc: Jason Gunthorpe <jgg@ziepe.ca>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Dan Williams <dan.j.williams@intel.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: John Hubbard <jhubbard@nvidia.com>
    Cc: Jérôme Glisse <jglisse@redhat.com>
    Cc: Jan Kara <jack@suse.cz>
    Cc: Dan Williams <dan.j.williams@intel.com>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: linux-mm@kvack.org
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: linux-samsung-soc@vger.kernel.org
    Cc: linux-media@vger.kernel.org
    Cc: Bjorn Helgaas <bhelgaas@google.com>
    Cc: linux-pci@vger.kernel.org
    Link: https://patchwork.freedesktop.org/patch/msgid/20210204165831.2703772-3-daniel.vetter@ffwll.ch
    636b21b5
proc.c 9.69 KB