• Kemeng Shi's avatar
    blk-iocost: Trace vtime_base_rate instead of vtime_rate · 63c9eac4
    Kemeng Shi authored
    Since commit ac33e91e ("blk-iocost: implement vtime loss
    compensation") rename original vtime_rate to vtime_base_rate
    and current vtime_rate is original vtime_rate with compensation.
    The current rate showed in tracepoint is mixed with vtime_rate
    and vtime_base_rate:
    1) In function ioc_adjust_base_vrate, the first trace_iocost_ioc_vrate_adj
    shows vtime_rate, the second trace_iocost_ioc_vrate_adj shows
    vtime_base_rate.
    2) In function iocg_activate shows vtime_rate by calling
    TRACE_IOCG_PATH(iocg_activate...
    3) In function ioc_check_iocgs shows vtime_rate by calling
    TRACE_IOCG_PATH(iocg_idle...
    
    Trace vtime_base_rate instead of vtime_rate as:
    1) Before commit ac33e91e ("blk-iocost: implement vtime loss
    compensation"), the traced rate is without compensation, so still
    show rate without compensation.
    2) The vtime_base_rate is more stable while vtime_rate heavily depends on
    excess budeget on current period which may change abruptly in next period.
    Signed-off-by: default avatarKemeng Shi <shikemeng@huawei.com>
    Acked-by: default avatarTejun Heo <tj@kernel.org>
    Link: https://lore.kernel.org/r/20221018121932.10792-4-shikemeng@huawei.comSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
    63c9eac4
blk-iocost.c 97.1 KB